Tweak tolerance in EWMR tests #125773
Merged
Tweak tolerance in EWMR tests #125773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen occasional failures with the existing tolerance, in `testEwmr_threadSafe` which contains some randomness. We were asserting the result of a lot of f.p. operations with a tolerance of 1.0e-13. The highest error I saw in any of the reported failures was 1.2e-13. This PR increases the tolerance to 2.0e-13 which should allow all those to pass. Fixes elastic#124692
PeteGillinElastic
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
Thanks! |
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
We have seen occasional failures with the existing tolerance, in `testEwmr_threadSafe` which contains some randomness. We were asserting the result of a lot of f.p. operations with a tolerance of 1.0e-13. The highest error I saw in any of the reported failures was less than 1.2e-13. This PR increases the tolerance to 2.0e-13 which should allow all those to pass. Fixes elastic#124692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen occasional failures with the existing tolerance, in
testEwmr_threadSafewhich contains some randomness. We were asserting the result of a lot of f.p. operations with a tolerance of 1.0e-13. The highest error I saw in any of the reported failures was less than 1.2e-13. This PR increases the tolerance to 2.0e-13 which should allow all those to pass.Fixes #124692